Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InjectionPointModifier for repeated annotations on method parameters; add grpc test #44961

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Dec 6, 2024

Fixes #44932

After some digging into the code in InjectionPointModifier, it seems that the condition is basically a leftover from before we changed how this transformer works for parameters and should not be needed.
I did some local testing but I'll let the CI prove me wrong :)

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/grpc gRPC labels Dec 6, 2024

This comment has been minimized.

Copy link

quarkus-bot bot commented Dec 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8ce8779.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier
Copy link
Member

@mkouba can you have a look?

@cescoffier cescoffier requested a review from mkouba December 9, 2024 07:42
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I think that we could merge this pr but I wonder if there should be a test in ArC too because it's a general problem, not grpc-specific. If I'm not mistaken, any repeating qualifier used in a CDI constructor/initializer method would fail.

We could that test in a follow-up pr though.

@manovotn WDYT?

@manovotn
Copy link
Contributor Author

manovotn commented Dec 9, 2024

Looks good and I think that we could merge this pr but I wonder if there should be a test in ArC too because it's a general problem, not grpc-specific. If I'm not mistaken, any repeating qualifier used in a CDI constructor/initializer method would fail.

Yea, the same occurred to me 👍

@manovotn manovotn merged commit fbe2d6e into quarkusio:main Dec 9, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 9, 2024
@manovotn manovotn deleted the grpcMultipleInterceptorsFix branch December 9, 2024 09:15
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.4 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grpc client interceptors are not registered when injected via constructor
4 participants