Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.smallrye.common:smallrye-common-bom from 2.8.0 to 2.9.0 #44954

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 5, 2024

Bumps io.smallrye.common:smallrye-common-bom from 2.8.0 to 2.9.0.

Release notes

Sourced from io.smallrye.common:smallrye-common-bom's releases.

2.9.0

  • #386 Release 2.9.0
  • #384 Make sure every module exports its packages
  • #383 Fix (again) invalid module name
  • #381 Do not use Unsafe on Java 22+
  • #380 Fix incorrect module name
  • #379 Use JarFile.OPEN_READ instead of ZipFile
  • #378 Open JAR in MR mode in all situations
  • #376 Fix javadoc issue by swapping task order
  • #375 Fix release build
  • #374 Replicate Maven rules more exactly
  • #373 Add useful toString to all version iterators
  • #372 Make ResourceUtils public
  • #371 Bump version.vertx from 4.5.10 to 4.5.11
  • #369 Allow traversal of root JAR directory and hidden directories
  • #368 Always use a URL stream handler for path-based resources
  • #367 Do not return a resource for non-existent filesystem files
  • #365 Add resource loader method to load the JAR manifest
  • #364 Fix URL construction for JAR resources
  • #361 Add resource method to list code signers
  • #360 Add resource loader method to get base URL
  • #349 Move baseline to Java 17
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @gastaldi.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [io.smallrye.common:smallrye-common-bom](https://github.com/smallrye/smallrye-common) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/smallrye/smallrye-common/releases)
- [Commits](smallrye/smallrye-common@2.8.0...2.9.0)

---
updated-dependencies:
- dependency-name: io.smallrye.common:smallrye-common-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Dec 5, 2024
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Dec 5, 2024
@gastaldi
Copy link
Contributor

gastaldi commented Dec 5, 2024

This fixes the test failures in quarkusio/registry.quarkus.io#268, so I'd like it to be backported to the next 3.15. Any objections @dmlloyd?

@dmlloyd
Copy link
Member

dmlloyd commented Dec 5, 2024

Sounds good to me.

@gastaldi
Copy link
Contributor

gastaldi commented Dec 5, 2024

@dependabot merge

@dependabot dependabot bot merged commit 9777061 into main Dec 6, 2024
51 checks passed
@dependabot dependabot bot deleted the dependabot/maven/io.smallrye.common-smallrye-common-bom-2.9.0 branch December 6, 2024 02:01
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 6, 2024
Copy link

quarkus-bot bot commented Dec 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5292679.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 devtools/cli

io.quarkus.cli.plugin.PluginCatalogServiceTest.shouldSyncWhenProjectFileIsNewerThanCatalog - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.plugin.PluginCatalogServiceTest.shouldSyncWhenProjectFileIsNewerThanCatalog(PluginCatalogServiceTest.java:109)

⚙️ JVM Tests - JDK 17 Windows

📦 independent-projects/resteasy-reactive/server/vertx

org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldCallOnCloseOnServer - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

@gsmet
Copy link
Member

gsmet commented Dec 9, 2024

For the context: the fix @gastaldi needs is related to version ordering.

@gsmet
Copy link
Member

gsmet commented Dec 9, 2024

@gastaldi let's always make sure we backport to the current version before adding the LTS label as we need bake time. Will push this one to 3.17 this week.

@gsmet gsmet modified the milestones: 3.18 - main, 3.17.4 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/component-upgrade triage/backport-3.15 triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants