Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing reproducers #44901

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Testing reproducers #44901

merged 3 commits into from
Dec 4, 2024

Conversation

…invoker"

This is because these tests use the Maven invoker.
@Ladicek
Copy link
Contributor Author

Ladicek commented Dec 3, 2024

Probably best to review each commit in isolation, because an aggregate view shows strange changes. I renamed the kotlin integration tests module to kotlin-maven-invoker and then renamed kotlin-serialization to kotlin, because that uses the standard @QuarkusTest facility and so deserves the shorter name.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

…"kotlin"

This is because these tests use the standard `@QuarkusTest` facility.
@Ladicek Ladicek force-pushed the testing-reproducers branch from bdc8597 to 5d11efe Compare December 3, 2024 15:10
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Dec 3, 2024
Copy link

quarkus-bot bot commented Dec 3, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5d11efe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member

gsmet commented Dec 3, 2024

Very nice initiative!

Copy link
Contributor

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@geoand geoand merged commit 0ac0e12 into quarkusio:main Dec 4, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 4, 2024
@Ladicek Ladicek deleted the testing-reproducers branch December 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kotlin area/testing
Projects
Development

Successfully merging this pull request may close these issues.

4 participants