Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRye Fault Tolerance: upgrade to 6.7.0 #44831

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Nov 29, 2024

This commit not only bumps the SmallRye Fault Tolerance version, but also adapts the extension to the extensive changes made in this version.

This especially includes:

  • deprecation of FaultTolerance and @ApplyFaultTolerance; replacements are Guard, TypedGuard and @ApplyGuard
  • new smallrye.faulttolerance.* configuration properties, together with adaptation to quarkus.fault-tolerance.*

Most changes in this commit are added tests, which all adapt already existing tests in SmallRye Fault Tolerance.

Fixes #24533

This commit not only bumps the SmallRye Fault Tolerance version, but also
adapts the extension to the extensive changes made in this version.

This especially includes:

- deprecation of `FaultTolerance` and `@ApplyFaultTolerance`; replacements
  are `Guard`, `TypedGuard` and `@ApplyGuard`
- new `smallrye.faulttolerance.*` configuration properties, together with
  adaptation to `quarkus.fault-tolerance.*`

Most changes in this commit are added tests, which all adapt already existing
tests in SmallRye Fault Tolerance.
Copy link

github-actions bot commented Nov 29, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Nov 29, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8e19875.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@gsmet
Copy link
Member

gsmet commented Nov 29, 2024

Looks like a candidate for an entry in the migration guide :).

@Ladicek
Copy link
Contributor Author

Ladicek commented Nov 29, 2024

I plan to add a link to the release announcement, which has more details and links to migration guides, to conserve space. There's technically no breaking change here, although migration is certainly a good idea :-)

@gsmet
Copy link
Member

gsmet commented Nov 29, 2024

Yeah, so even if not breaking, please make sure people have the info about how to migrate to the current way of doing things.

I'm fine with a quick summary of the change + link to the release notes if they contain all relevant info.

@Ladicek
Copy link
Contributor Author

Ladicek commented Nov 29, 2024

Done: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.18#smallrye-fault-tolerance

Copy link

quarkus-bot bot commented Nov 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8e19875.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor\#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redis:7 at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:124) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redis:7
	at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:124)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)
  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

@gsmet gsmet merged commit b0c3678 into quarkusio:main Nov 29, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 29, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Nov 29, 2024
@gsmet
Copy link
Member

gsmet commented Nov 29, 2024

@ozangunalp is there something we could do to make the SmallRye Reactive Messaging test above more robust?

@Ladicek Ladicek deleted the fault-tolerance-6.7.0 branch November 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fault Tolerance in config file could use dash seperated names
3 participants