Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline otel dependencies #44772

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Nov 27, 2024

Related to #44771

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Nov 27, 2024
bom/application/pom.xml Show resolved Hide resolved
bom/application/pom.xml Outdated Show resolved Hide resolved
bom/application/pom.xml Outdated Show resolved Hide resolved
@rsvoboda
Copy link
Member

@brunobat how does the number of <groupId>io.opentelemetry changes after your change?

https://central.sonatype.com/artifact/io.quarkus/quarkus-bom shows 386 <groupId>io.opentelemetry hits

@brunobat
Copy link
Contributor Author

brunobat commented Nov 27, 2024

@brunobat how does the number of <groupId>io.opentelemetry changes after your change?

https://central.sonatype.com/artifact/io.quarkus/quarkus-bom shows 386 <groupId>io.opentelemetry hits

I'm afraid I can still see the excluded artifacts in the flattened-quarkus-bom-999-SNAPSHOT.pom
No sure how to find or generate the sbom locally.

@aloubyansky
Copy link
Member

Given that we use our own flattening goal and it includes a filtering option, I could enhance it a bit to accept patterns and we could simply filter out based on a pattern.

@brunobat
Copy link
Contributor Author

Given that we use our own flattening goal and it includes a filtering option, I could enhance it a bit to accept patterns and we could simply filter out based on a pattern.

@aloubyansky, do you suggest we keep and merge this PR? Will it be useful to your work?

@aloubyansky
Copy link
Member

@brunobat this PR removes a couple of BOM imports and one constraint, afaics, if you do want to remove them then we can merge it. Do we really want to remove them though?
When it comes to the instrumentation BOM, those exclusions can be removed, they are not effective.

This comment has been minimized.

@aloubyansky
Copy link
Member

Here is the filtering part #44792

bom/application/pom.xml Outdated Show resolved Hide resolved
@brunobat
Copy link
Contributor Author

Here is the filtering part #44792

Thanks @aloubyansky, good to know the place where that filtering can be configured.

Copy link

quarkus-bot bot commented Nov 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2ed844d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/panache/hibernate-reactive-rest-data-panache/deployment

io.quarkus.hibernate.reactive.rest.data.panache.deployment.repository.PanacheRepositoryResourcePutMethodTest.shouldUpdateComplexObject - History

  • 1 expectation failed. JSON path name doesn't match. Expected: is "updated collection" Actual: empty collection - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path name doesn't match.
Expected: is "updated collection"
  Actual: empty collection

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)

📦 integration-tests/opentelemetry-vertx-exporter

io.quarkus.it.opentelemetry.vertx.exporter.grpc.SimpleGrpcNoTLSNoCompressionTest.test - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.opentelemetry.vertx.exporter.AbstractExporterTest Expecting Optional to contain a value but it was empty within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.it.opentelemetry.vertx.exporter.AbstractExporterTest 
Expecting Optional to contain a value but it was empty within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:806)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 89bc558 into quarkusio:main Nov 29, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants