Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Traceless annotation #44724

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Nov 26, 2024

After this discussion on #43885 pull request, we decided to remove the annotation and to work only with the quarkus.otel.traces.suppress-application-uris property.

I created another issue for tracking the @Traceless annotation. #44733

Copy link

quarkus-bot bot commented Nov 26, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

Copy link

quarkus-bot bot commented Nov 26, 2024

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@mcruzdev
Copy link
Contributor Author

cc: @geoand @brunobat @michalvavrik

@mcruzdev mcruzdev marked this pull request as ready for review November 26, 2024 15:40
@gastaldi
Copy link
Contributor

For context, #43885 introduced the annotation (targetting 3.18) and this PR removes it, so no API breaking changes would be introduced if this PR is merged before 3.18 is released

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 26, 2024

This comment has been minimized.

Copy link

github-actions bot commented Nov 26, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@mcruzdev
Copy link
Contributor Author

this one is related, I will take a look

@gastaldi
Copy link
Contributor

Test failures seem related? 🤔

@mcruzdev
Copy link
Contributor Author

I think yes...

Copy link

quarkus-bot bot commented Nov 26, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 77f783f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@geoand geoand merged commit 5510bc8 into quarkusio:main Nov 27, 2024
32 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 27, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 27, 2024
@traceless
Copy link

Can you close this issue, because your title include the character '@-Traceless' , i will receive a message reminder from this issue...

@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

We can't close the related issues or PRs as they are part of ongoing work to improve our project.

I suggest deactivating notifications from the repo entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants