-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC Redis Token State Manager extension #44546
Add OIDC Redis Token State Manager extension #44546
Conversation
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a small comment about the Redis key name.
Now, I'm wondering about the future. I was planning to extract Redis to a QV repository. I believe this will come with it (as well as the cache implementation). It's not planned for "now", but something for the future.
.../main/java/io/quarkus/oidc/redis/token/state/manager/runtime/OidcRedisTokenStateManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but see the question by @cescoffier
b58fe91
to
5e27bb4
Compare
There is only a couple QV projects I'd use in production. I think you or Sergey needs to decide this because moving it will come with a price. You won't have to just test and release this OIDC Redis extension with every Quarkus release, but also with every QV Redis release. This way, you will have matching tested version for every Quarkus/Redis/OIDC combination. I just checked OIDC Proxy extension in QV and I don't think things are automated in QV side (though I know next to nothing about Quarkiverse). If that will need to be maintained manually, it will be extra work. Maybe you could move it into shared QV project with Redis? |
This comment has been minimized.
This comment has been minimized.
.../main/java/io/quarkus/oidc/redis/token/state/manager/runtime/OidcRedisTokenStateManager.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/oidc/redis/token/state/manager/runtime/OidcRedisTokenStateManager.java
Outdated
Show resolved
Hide resolved
5e27bb4
to
c3440a4
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik, very neat and simple, thanks @Ladicek for the review
@calvernaz, FYI |
Hi @michalvavrik @cescoffier |
Status for workflow
|
quarkus-oidc-redis-token-state-manager
#44382