Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer lookup and generate static resources for web dep locator #44128

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Oct 28, 2024

Fixes #44126

Copy link

quarkus-bot bot commented Oct 28, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2024

This PR also fixe a wrong directory in the doc cc @tqvarnst

This comment has been minimized.

@tqvarnst
Copy link
Contributor

This issue is kind of annoying, and to work around it, I have to CTRL-C out of dev mode and start dev mode again, so it would be nice to have this backported to 3.15 as well.

Copy link

github-actions bot commented Oct 28, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@aloubyansky
Copy link
Member

This is a breaking change, isn't it? The new code doesn't look in the project resources at all?
BTW, the previous code made some assumptions that it shouldn't do.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Oct 28, 2024
@aloubyansky
Copy link
Member

@ia3andy I pushed an enhancement to make it easier to process runtime resources as the first commit

Copy link

quarkus-bot bot commented Oct 28, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 693cdca.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2024

thanks @aloubyansky this is pretty cool! I will use the same for Roq :)

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2024

@aloubyansky could you approve this

@ia3andy ia3andy merged commit 123ea8e into quarkusio:main Oct 28, 2024
50 of 53 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 28, 2024
@ia3andy ia3andy deleted the fix-web-dep-locator branch October 28, 2024 13:46
@gsmet gsmet removed this from the 3.17 - main milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation triage/backport-3.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources should be found from the classpath instead in web dep locator
4 participants