Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoClassDefFoundError when using vertx without http #44072

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

brunobat
Copy link
Contributor

This is a follow up to #43919

Added a new IT test with minimal setup because all other tests use HTTP to retrieve the telemetry, therefore causing a blank spot in the coverage.

Copy link

quarkus-bot bot commented Oct 24, 2024

/cc @radcortez (opentelemetry)

@gsmet
Copy link
Member

gsmet commented Oct 24, 2024

I think we have to backport it to 3.15 too? Or it's an issue only for 3.16+?

Copy link

quarkus-bot bot commented Oct 24, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d2b8866.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@brunobat
Copy link
Contributor Author

Yes @gsmet, we need to backport it. It is built on top of this issue: #43919
One problem found the other.

@brunobat brunobat merged commit 449be2a into quarkusio:main Oct 25, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 25, 2024
@famod famod linked an issue Oct 28, 2024 that may be closed by this pull request
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 28, 2024
@gsmet gsmet modified the milestones: 3.16.1, 3.15.2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.16.0: ExtendedQuarkusVertxHttpMetrics not found in tests
3 participants