-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid double registration of providers #44052
Conversation
This comment has been minimized.
This comment has been minimized.
@cdsap The failure reported above look a bit concerning ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes things a lot more confusing. I'm not saying the new logic is wrong, just that it's very hard to follow.
We need to make sure the purpose of the sets is understandable and the new code is mixing them all to make it work for what you want to achieve and we completely lost the initial semantic.
I can take a stab at it if you don't feel like it.
.../deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java
Outdated
Show resolved
Hide resolved
.../deployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java
Outdated
Show resolved
Hide resolved
I agree. I just wanted to minimize the changes. Let me rework this properly. |
Hi @gsmet,
The flaky execution is caused by a
Similarly, the failing executions are related to a
What are your thoughts on this? Is the service degradation a temporary issue, or should I avoid building the Docker images during these integration tests? |
90ad3e1
to
374a502
Compare
This comment has been minimized.
This comment has been minimized.
374a502
to
f26bd1d
Compare
f26bd1d
to
0af8ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and fixed a small typo, let's merge when CI is green.
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | MicroProfile TCKs Tests | Verify |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ MicroProfile TCKs Tests #
- Failing: tcks/microprofile-opentelemetry
📦 tcks/microprofile-opentelemetry
✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.0:test (tracing) on project quarkus-tck-microprofile-opentelemetry: There are test failures.
Please refer to /home/runner/work/quarkus/quarkus/tcks/microprofile-opentelemetry/target/surefire-reports-tracing for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
When
useBuiltinProviders
from RESTEasy istrue
, theavailableProviders
will be automatically discovered by RESTEasy. IfavailableProviders
are also included, RESTEasy will warn about double regisration.