Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide DnsServerAddressStreamProviders Messages During Native Build #43957

Merged

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Oct 18, 2024

When building a native executable on macOS, the following message is printed during analysis:

[11:59:56,705 WARN  [io.net.res.dns.DnsServerAddressStreamProviders] Cannot find io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider in the classpath, falling back to system defaults. This may result in incorrect DNS resolutions on macOS. Check whether you have a dependency on 'io.netty:netty-resolver-dns-native-macos'

This commit suppresses this unnecessary message by modifying the DisableLoggingFeature to set the logger level for this message to SEVERE.

Fix #40938

When building a native executable on macOS, the following message is printed during analysis:

[11:59:56,705 WARN  [io.net.res.dns.DnsServerAddressStreamProviders] Cannot find io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider in the classpath, falling back to system defaults. This may result in incorrect DNS resolutions on macOS. Check whether you have a dependency on 'io.netty:netty-resolver-dns-native-macos'

This commit suppresses this unnecessary message by modifying the DisableLoggingFeature to set the logger level for this message to SEVERE.
Copy link

quarkus-bot bot commented Oct 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit be318b5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet
Copy link
Member

gsmet commented Oct 18, 2024

So we don't need the specific MacOS resolver?

@cescoffier
Copy link
Member Author

@gsmet no. I never had any issue.

@gsmet gsmet merged commit 84823f6 into quarkusio:main Oct 21, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 21, 2024
@cescoffier cescoffier deleted the hide-netty-message-during-native-build branch October 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netty:LogCleanupFilterBuildItem does not remove a message
2 participants