Fix ObservabilityDevServicesConfigBuildItem usage - can be multiple, fix dup logging output

[alesj]

There can (and probably will be) multiple ObservabilityDevServicesConfigBuildItem instances,
since there can be multiple DevResources instances.
Currently only the last one would probably be used with this Optional<ObservabilityDevServicesConfigBuildItem> parameter?
This fixes ObservabilityDevServicesConfigBuildItem usage, so all are checked for potential DevUI contribution.

[alesj]

@melloware wdyt?

[melloware]

i like it

[github-actions]

🎊 PR Preview a4b05f7 has been successfully built and deployed to https://quarkus-pr-main-43945-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[phillip-kruger]

LGTM

[gsmet]

No need to change it here but we should really avoid using lambdas when they have no value. In this case a for loop would have been better.

Also configProps should never be null.

[alesj]

Fixed

[alesj]

@gsmet @melloware @brunobat any idea why am I not seeing any of this log from ObservabilityContainer when starting LGTM ...

    protected void addFileToContainer(byte[] content, String pathInContainer) {
        log.infof("Content [%s]: \n{}", pathInContainer, new String(content, StandardCharsets.UTF_8));
        withCopyToContainer(Transferable.of(content, 0777), pathInContainer);
    }

    @Override
    public void start() {
        log.infof("Starting %s ...", prefix());
        super.start();
    }

    @Override
    public void stop() {
        log.infof("Stopping %s...", prefix());
        super.stop();
    }

all I get is this -- which is still fine -- but would also like to see the stuff above

• https://gist.github.com/alesj/12cd8173bd2e4e2ede5d049ea3f658b0

[alesj]

@gsmet @melloware @brunobat any idea why am I not seeing any of this log from ObservabilityContainer when starting LGTM ...

    protected void addFileToContainer(byte[] content, String pathInContainer) {
        log.infof("Content [%s]: \n{}", pathInContainer, new String(content, StandardCharsets.UTF_8));
        withCopyToContainer(Transferable.of(content, 0777), pathInContainer);
    }

    @Override
    public void start() {
        log.infof("Starting %s ...", prefix());
        super.start();
    }

    @Override
    public void stop() {
        log.infof("Stopping %s...", prefix());
        super.stop();
    }

all I get is this -- which is still fine -- but would also like to see the stuff above

• https://gist.github.com/alesj/12cd8173bd2e4e2ede5d049ea3f658b0

OK, this is the "culprit" - in ObservabilityDevServiceProcessor ...

            StartupLogCompressor compressor = new StartupLogCompressor(
                    (launchMode.isTest() ? "(test) " : "") + devId + " Dev Services Starting:",
                    consoleInstalledBuildItem,
                    loggingSetupBuildItem,
                    s -> false,
                    s -> s.contains(getClass().getSimpleName())); // log if it comes from this class

[alesj]

OK, fixed that "missing" log stuff as well.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5b12d57.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

[brunobat]

It looks good to me now.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5b12d57.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.