Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass '--enable-monitoring=heapdump' unconditionally on windows #43896

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Don't pass '--enable-monitoring=heapdump' unconditionally on windows #43896

merged 2 commits into from
Oct 17, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 16, 2024

The feature is not supported on Windows

Closes #43895

@zakkak zakkak requested a review from galderz October 16, 2024 07:06
@zakkak zakkak marked this pull request as ready for review October 16, 2024 07:06
gsmet
gsmet reviewed Oct 16, 2024
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java Outdated
@@ -932,7 +932,10 @@ public NativeImageInvokerInfo build() {
}

List<NativeConfig.MonitoringOption> monitoringOptions = new ArrayList<>();
monitoringOptions.add(NativeConfig.MonitoringOption.HEAPDUMP);
if (!SystemUtils.IS_OS_WINDOWS || containerBuild) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use SmallRye Common OS instead? Something like OS.WINDOWS.isCurrent().

I'm not asking to change it everywhere but let's use this one when we add new code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use SmallRye Common OS instead? Something like OS.WINDOWS.isCurrent().

Sure.

I'm not asking to change it everywhere but let's use this one when we add new code.

I think I prefer changing it everywhere so that future me (and others I hope) will see what's being used and not mistakenly use SystemUtils :)

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@zakkak
Copy link
Contributor Author

zakkak commented Oct 16, 2024

The previous patch was resulting in an empty --enable-monitoring= parameter which resulted to:

Error: The '--enable-monitoring' option contains invalid value(s): . It can only contain 'heapdump', 'jfr', 'jvmstat', 'jmxserver' (experimental), 'jmxclient' (experimental), or 'all' (deprecated behavior: defaults to 'all' if no argument is provided).
[1/8] Initializing...                                                                                    (0.0s @ 0.19GB)
com.oracle.svm.core.util.UserError$UserException: The '--enable-monitoring' option contains invalid value(s): . It can only contain 'heapdump', 'jfr', 'jvmstat', 'jmxserver' (experimental), 'jmxclient' (experimental), or 'all' (deprecated behavior: defaults to 'all' if no argument is provided).

Should be fixed now.

@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 16, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@zakkak
Refactor: Use io.smallrye.common.os.OS
26c2c48 
Instead of org.apache.commons.lang3.SystemUtils;
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 17, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 26c2c48.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/mongodb-panache

✖ io.quarkus.it.mongodb.panache.ReflectionFreeSerializationTest.testReactiveBookEntity - History

  • com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input at [Source: REDACTED (\StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]-java.lang.RuntimeException`
java.lang.RuntimeException: 
com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]
	at io.restassured.internal.path.json.mapping.JsonPathJackson2ObjectDeserializer.deserialize(JsonPathJackson2ObjectDeserializer.java:30)
	at io.restassured.path.json.mapping.JsonPathObjectDeserializer$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.Jackson2Mapper.deserialize(Jackson2Mapper.groovy:58)
	at io.restassured.mapper.ObjectMapper$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.ObjectMapping.parseWithJackson2(ObjectMapping.groovy:254)
  • com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input at [Source: REDACTED (\StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]-java.lang.RuntimeException`
java.lang.RuntimeException: 
com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]
	at io.restassured.internal.path.json.mapping.JsonPathJackson2ObjectDeserializer.deserialize(JsonPathJackson2ObjectDeserializer.java:30)
	at io.restassured.path.json.mapping.JsonPathObjectDeserializer$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.Jackson2Mapper.deserialize(Jackson2Mapper.groovy:58)
	at io.restassured.mapper.ObjectMapper$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.ObjectMapping.parseWithJackson2(ObjectMapping.groovy:254)
  • com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input at [Source: REDACTED (\StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]-java.lang.RuntimeException`
java.lang.RuntimeException: 
com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]
	at io.restassured.internal.path.json.mapping.JsonPathJackson2ObjectDeserializer.deserialize(JsonPathJackson2ObjectDeserializer.java:30)
	at io.restassured.path.json.mapping.JsonPathObjectDeserializer$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.Jackson2Mapper.deserialize(Jackson2Mapper.groovy:58)
	at io.restassured.mapper.ObjectMapper$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.ObjectMapping.parseWithJackson2(ObjectMapping.groovy:254)

⚙️ Native Tests - Messaging1

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorIT.testRequestReply - History

  • iterable contents differ at index [2], expected: <reply-3> but was: <{"details":"Error id 4cf810ad-cecf-4dbf-90f8-1d39fd95c6cf-1","stack":""}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: iterable contents differ at index [2], expected: <reply-3> but was: <{"details":"Error id 4cf810ad-cecf-4dbf-90f8-1d39fd95c6cf-1","stack":""}>
	at io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply(KafkaConnectorTest.java:112)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
  • iterable contents differ at index [0], expected: <reply-1> but was: <{"details":"Error id 4cf810ad-cecf-4dbf-90f8-1d39fd95c6cf-1","stack":""}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: iterable contents differ at index [0], expected: <reply-1> but was: <{"details":"Error id 4cf810ad-cecf-4dbf-90f8-1d39fd95c6cf-1","stack":""}>
	at io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply(KafkaConnectorTest.java:112)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
  • iterable contents differ at index [0], expected: <reply-1> but was: <{"details":"Error id 4cf810ad-cecf-4dbf-90f8-1d39fd95c6cf-1","stack":""}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: iterable contents differ at index [0], expected: <reply-1> but was: <{"details":"Error id 4cf810ad-cecf-4dbf-90f8-1d39fd95c6cf-1","stack":""}>
	at io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply(KafkaConnectorTest.java:112)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@zakkak zakkak merged commit 1c1de90 into quarkusio:main Oct 17, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 17, 2024
@zakkak zakkak deleted the 2024-10-16-fix-43895 branch October 17, 2024 05:52
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 17, 2024
@zakkak zakkak mentioned this pull request Oct 21, 2024
Closed
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.0 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@galderz galderz Awaiting requested review from galderz

Assignees
No one assigned
Labels
area/core kind/bugfix triage/flaky-test
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

Don't pass '--enable-monitoring=heapdump' unconditionally on windows
2 participants
@zakkak @gsmet