SmallRye GraphQL 2.11

[jmartisk]

Fixes #42534 (and more)

[jmartisk]

FYI @RoMiRoSSaN and @dpolysiou this includes your commits
Also @mskacelik

[github-actions]

🙈 The PR is closed and the preview is expired.

[gsmet]

Overall, this looks good to me but I added a few questions and comments.

Thanks!

[gsmet]

Not sure if it's just me misunderstanding but this looks confusing to me.

AFAICS from the first sentence, ApplicationScoped beans won't work well.

But the second sentence says some beans are application scoped and then it says This guarantees.... So you might think that the fact that they are application scoped guarantees it to work. Which is not the case unless I'm mistaken?

Also is it a general limitation of the TLS registry because it seems quite problematic to require all the beans to be request scoped?

[jmartisk]

Good point, I'll clarify that a bit.
Yeah, I think we simply have to make the beans short-lived to get new instances configured with the new certificates. We probably don't want to hot-swap it inside a running GraphQL client instance because that would require closing the underlying HTTP client (and there might be running websocket connections etc), that would be very dangerous.

Btw Dynamic clients are Dependent right now, we plan to figure out a way to make that configurable.

[gsmet]

Please add since and forRemoval. Valid for all the configuration properties you deprecated.

[gsmet]

Just to make sure, this is consistent with the other extensions, right?

[jmartisk]

Yeah, we copied this from the gRPC client

[cescoffier]

Yes, I confirm this is the name used everywhere and documented in the ADR.

[jmartisk]

Hopefully fixed the Windows failures now 🫤

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 3375bb2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3375bb2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/panache/hibernate-reactive-rest-data-panache/deployment

✖ io.quarkus.hibernate.reactive.rest.data.panache.deployment.repository.PanacheRepositoryResourcePutMethodTest.shouldUpdateComplexObject - History

• 1 expectation failed. JSON path name doesn't match. Expected: is "updated collection" Actual: empty collection - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
JSON path name doesn't match.
Expected: is "updated collection"
  Actual: empty collection

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)