Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev UI better reconnect #43841

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Dev UI better reconnect #43841

merged 2 commits into from
Oct 14, 2024

Conversation

phillip-kruger
Copy link
Member

This PR does 2 things:

  • Change the mouse pointer to wait when the server is restarting. This gives the user some more indication that the server is offline (other than the icon on the bottom left corner)
  • Exponential backoff the retry attempts, with a max of 10. If the server is not up by then, it's not a normal restart, so we display a popup to allow manual reconnect.

dev_ui_reconnect

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@phillip-kruger
Copy link
Member Author

phillip-kruger commented Oct 14, 2024 •
edited
Loading

| There is a grammar error in the pop up. Hold off merging let me fix it first
Ok this is fixed now.

@phillip-kruger phillip-kruger force-pushed the dev-ui-better-reconnect branch 2 times, most recently from e334189 to ea5d74b Compare October 14, 2024 05:21
@phillip-kruger
Dev UI better reconnect
76557c7 
Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger phillip-kruger force-pushed the dev-ui-better-reconnect branch from ea5d74b to 76557c7 Compare October 14, 2024 06:34
@geoand geoand requested a review from cescoffier October 14, 2024 06:59
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 14, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 76557c7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 8d1764e into quarkusio:main Oct 14, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 14, 2024
@gsmet
Copy link
Member

gsmet commented Oct 14, 2024

Nice improvement!

@phillip-kruger phillip-kruger mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/vertx triage/flaky-test
Projects
None yet
Milestone
3.16.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@phillip-kruger @gsmet @cescoffier @melloware