Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing a Dev Service doc fixes #43789

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Writing a Dev Service doc fixes #43789

merged 1 commit into from
Oct 10, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Oct 9, 2024

This removes the extra brace ({) in the snippet

@gastaldi gastaldi changed the title Remove extra brace Writing a Dev Service doc fixes Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@holly-cummins
Copy link
Contributor

Thanks!

@gastaldi
Copy link
Contributor Author

gastaldi commented Oct 9, 2024

Hm, I wonder why you don't have the karma to make PR mergeable on approval. Perhaps @gsmet may help

@gastaldi gastaldi requested review from geoand and gsmet October 9, 2024 23:20
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I made a small suggestion, feel free to ignore if you have a strong opinion :).

docs/src/main/asciidoc/extension-writing-dev-service.adoc Outdated Show resolved Hide resolved
Fix broken link

Update docs/src/main/asciidoc/extension-writing-dev-service.adoc

Co-authored-by: Guillaume Smet <[email protected]>
Copy link

quarkus-bot bot commented Oct 10, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit d3c69b0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit aa93848 into quarkusio:main Oct 10, 2024
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 10, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 10, 2024
@gastaldi gastaldi deleted the doc_fix branch October 10, 2024 11:50
@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.2 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants