WebSockets Next: make it possible to store user data in a connection

[mkouba]

• resolves websocket-next api - missing user properties map #43772

[github-actions]

🙈 The PR is closed and the preview is expired.

[Ladicek]

You don't really need the string key. The object identity of the key is itself good enough.

This

static class Key<T> {
}

is all you need.

[mkouba]

Not really. This way you would need to use the object reference as a key. Always. That's not what we want/need. A string-based key is IMO more practical.

[Ladicek]

Well, you're risking collisions, so the string keys will have to be namespaced... Not a fan. But your choice.

[mkouba]

This is for user data. I don't expect collisions there. Anyway, we risk collisions pretty much everywhere when it comes to MP Config and application properties 🤷.

[gastaldi]

Shouldn't it be an int here?

Suggested change

	public static TypedKey<Integer> forInt(String val) {
	public static TypedKey<Integer> forInt(int val) {

[gastaldi]

and then return new TypedKey<>(String.valueOf(val));?

[mkouba]

No. The value is actually the key. I should rename the param.

[mkouba]

In other words, this factory method is used to create a typed key with the specified string value. I.e. you expect the value to be integer, but the key is still string-based.

[gastaldi]

Can we hide this implementation detail by providing extra put/get/remove methods in the UserData?

[mkouba]

It's actually not an implementation detail. We want the users to use the typed key in order to use generics to verify the type of the value in put() and to cast the value automatically when obtaining the value with get(). We could add getString() and putString() etc. but I don't think it would make the API more clear or useful. Also we would have to keep the generic way so that it could be used for "custom" types, similar to https://github.com/quarkusio/quarkus/pull/43787/files#diff-a63047e6c7bf732258f9858dcb9cb5303fa5ebe9756eb27cc970a4130190bdc3R62.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit a3d3a32.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a3d3a32.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.