Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GraalVM 23.1 dev builds based on OpenJDK #43716

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Handle GraalVM 23.1 dev builds based on OpenJDK #43716

merged 1 commit into from
Oct 10, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 4, 2024

Fixes #42893

@zakkak zakkak requested a review from galderz October 4, 2024 21:53
@quarkus-bot quarkus-bot bot added the area/core label Oct 4, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will let you merge later if you want to wait for @galderz 's review!

@zakkak zakkak force-pushed the 2024-10-05-fix-42893 branch from 4b94f73 to f1a0183 Compare October 7, 2024 11:47
@zakkak
Copy link
Contributor Author

zakkak commented Oct 7, 2024

Rebased to resolve conflict.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@zakkak zakkak force-pushed the 2024-10-05-fix-42893 branch from f1a0183 to 55751ae Compare October 7, 2024 16:35
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 55751ae.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@zakkak zakkak merged commit 7a09a40 into quarkusio:main Oct 10, 2024
52 checks passed
@zakkak zakkak deleted the 2024-10-05-fix-42893 branch October 10, 2024 08:43
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@galderz galderz Awaiting requested review from galderz

Assignees
No one assigned
Labels
area/core kind/bugfix triage/flaky-test
Projects
None yet
Milestone
3.16.0.CR1
Development

Successfully merging this pull request may close these issues.

Quarkus fails to get GraalVM version from GraalVM CE builds based on OpenJDK instead of LabsJDK
2 participants
@zakkak @gsmet