Add overflow-x scroll

[mcruzdev]

Changes

Apply overflow-x: scroll and display: block to .stacktrace class.

Old behavior

New behavior

Now the container is not overflowing:

Fixes #43551

[gsmet]

Should we wrap instead? It sounds like a better behavior than having to scroll?

[phillip-kruger]

I have no preference for wrap or scroll :) Either way happy with the change.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c9ea0c6.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	Native Tests - Data6	Upload build reports	⚠️ Check →	Logs	Raw logs	🔍

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

• Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

---

⚙️ Native Tests - Security2

📦 integration-tests/oidc-client-wiremock

✖ io.quarkus.it.keycloak.OidcClientInGraalITCase.testGetAccessTokenWithConfiguredExpiresIn - History

• expected: <true> but was: <false> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[gsmet]

Sorry, I should have been a bit more assertive in my review as I think we really should switch to wrapping. While this PR is an improvement over the existing behavior, having to scroll is really annoying, either when trying to see the whole line or even when copy/pasting the error.

We have a good example of that when pasting stack trace in GitHub with backticks, it can quickly get annoying and sometimes, I even switch to quoting so that you have the nice wrapping behavior.

@mcruzdev any chance you could create a follow-up PR with some wrapping instead as you seem to agree with it in your reaction? Thanks!

[mcruzdev]

Sorry, I should have been a bit more assertive in my review as I think we really should switch to wrapping. While this PR is an improvement over the existing behavior, having to scroll is really annoying, either when trying to see the whole line or even when copy/pasting the error.

We have a good example of that when pasting stack trace in GitHub with backticks, it can quickly get annoying and sometimes, I even switch to quoting so that you have the nice wrapping behavior.

@mcruzdev any chance you could create a follow-up PR with some wrapping instead as you seem to agree with it in your reaction? Thanks!

Hi @gsmet obviously! Another point that I would to talk about is TemplateHtmlBuilder, we Java code with HTML code together what is the possibility to change it to use Qute?

This question above is for the future (maybe), I will create another PR that adds wrapping behavior, thank you!

[gsmet]

I think the point of using some low level code instead of Qute is to avoid having a dependency on Qute in virtually every app as the Dev UI or error pages would require it.

It's not ideal but sometimes you have to stay a bit more low level.

[mcruzdev]

Hmmm... It makes sense! TY

[phillip-kruger]

Maybe we can add two small icons. One that copies the stackstrace into clipboard and one that switch between wrapped and non-wrapped (default to wrapped ?) w.d.y.t ?

[gsmet]

Do you see a reason why you would prefer it unwrapped? I must admit I can't see a good reason for it.

[phillip-kruger]

I just think some people might prefer that ?