Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @HEAD and @OPTIONS in sub-resources #43440

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 23, 2024

This is the same exact support as exists for normal Resource methods

This is the same exact support as exists for normal
Resource methods

Fixes: quarkusio#43422
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 23, 2024
@geoand geoand changed the title Support @HEAD and @OPTIONS in sub-resources Support @HEAD and @OPTIONS in sub-resources Sep 23, 2024
@geoand geoand merged commit 4ab1614 into quarkusio:main Sep 23, 2024
45 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 23, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 23, 2024
Copy link

quarkus-bot bot commented Sep 23, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 898b038.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
	at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

⚙️ JVM Tests - JDK 17 Windows

📦 independent-projects/resteasy-reactive/server/vertx

org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldNotTryToSendToClosedSink - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

@geoand geoand deleted the #43422 branch September 23, 2024 14:53
@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.2 Oct 18, 2024
jedla97 added a commit to jedla97/quarkus-test-suite that referenced this pull request Nov 12, 2024
jedla97 added a commit to jedla97/quarkus-test-suite that referenced this pull request Nov 12, 2024
jedla97 added a commit to jedla97/quarkus-test-suite that referenced this pull request Nov 13, 2024
jedla97 added a commit to jedla97/quarkus-test-suite that referenced this pull request Nov 14, 2024
rsvoboda pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP HEAD to @GET endpoint of (reactive) Jakarta RESTful web services sub resource returns 405
3 participants