Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for exceptions in threads on class loader test #43286

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Check for exceptions in threads on class loader test #43286

merged 1 commit into from
Sep 16, 2024

Conversation

pcasaes
Copy link
Contributor

@pcasaes pcasaes commented Sep 13, 2024 •
edited by geoand
Loading

Attempts to test against #43158

The original test would pass if an exception bubbled up into a worker thread.

@pcasaes
Check for exceptions in threads on class loader test
66608a7 
Attempts to test against
quarkusio#43158

The original test would pass if an exception bubbled up into a worker thread.
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Sep 13, 2024
@pcasaes pcasaes mentioned this pull request Sep 13, 2024
Closed
geoand
geoand approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 66608a7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit bd1b8d7 into quarkusio:main Sep 16, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 16, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@mariofusco mariofusco mariofusco approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
3.16.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@pcasaes @mariofusco @geoand