-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Boolean serializer #43064
Fix Boolean serializer #43064
Conversation
/cc @mariofusco @geoand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Don't know if all the Jackson changes are going to be back ported to 3.14, if not I can also do a PR to fix that branch, as that will become 3.15, and will be LTS right? |
I am sure which part is already in 3.14, @mariofusco can clarify that |
3.14 doesn't have #42954 which adds deserializer and refactors the serializer, so if that one doesn't get back ported this fix won't apply cleanly in the 3.14, a PR targeting that branch would be needed so at least the serializer is fixed there |
Right, the deserializer stuff won't be backported |
Status for workflow
|
We didn't have a mapping for boxed boolean to primitive as the jackson generator method has a primitive parameter, without that change we get a
java.lang.NoSuchMethodError: 'void com.fasterxml.jackson.core.JsonGenerator.writeBoolean(java.lang.Boolean)'
Handled this scenario and added a test.
Fixes #43057