Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boolean serializer #43064

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix Boolean serializer #43064

merged 1 commit into from
Sep 6, 2024

Conversation

luneo7
Copy link
Contributor

@luneo7 luneo7 commented Sep 5, 2024

We didn't have a mapping for boxed boolean to primitive as the jackson generator method has a primitive parameter, without that change we get a java.lang.NoSuchMethodError: 'void com.fasterxml.jackson.core.JsonGenerator.writeBoolean(java.lang.Boolean)'

Handled this scenario and added a test.

Fixes #43057

@quarkus-bot quarkus-bot bot added the area/rest label Sep 5, 2024
@luneo7
Copy link
Contributor Author

luneo7 commented Sep 5, 2024

/cc @mariofusco @geoand

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luneo7
Copy link
Contributor Author

luneo7 commented Sep 6, 2024

Don't know if all the Jackson changes are going to be back ported to 3.14, if not I can also do a PR to fix that branch, as that will become 3.15, and will be LTS right?

@geoand
Copy link
Contributor

geoand commented Sep 6, 2024

I am sure which part is already in 3.14, @mariofusco can clarify that

@luneo7
Copy link
Contributor Author

luneo7 commented Sep 6, 2024

3.14 doesn't have #42954 which adds deserializer and refactors the serializer, so if that one doesn't get back ported this fix won't apply cleanly in the 3.14, a PR targeting that branch would be needed so at least the serializer is fixed there

@geoand
Copy link
Contributor

geoand commented Sep 6, 2024

Right, the deserializer stuff won't be backported

Copy link

quarkus-bot bot commented Sep 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c9e6130.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit fe706f2 into quarkusio:main Sep 6, 2024
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 6, 2024
@luneo7 luneo7 deleted the fix-serializer branch September 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection-free-serializers serialization error
2 participants