Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC Client SPI #42879

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add OIDC Client SPI #42879

merged 1 commit into from
Aug 30, 2024

Conversation

sberyozkin
Copy link
Member

Fixes #42878

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation area/oidc labels Aug 29, 2024
@sberyozkin
Copy link
Member Author

sberyozkin commented Aug 29, 2024

I know we are supposed to try to close smaller issues, but I'd like to make sure we have a good support in LTS for the forthcoming Mailer XOAuth2 work...

Copy link

github-actions bot commented Aug 29, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link

quarkus-bot bot commented Aug 29, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 00db230.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Aug 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 00db230.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:973)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:823)

@sberyozkin
Copy link
Member Author

sberyozkin commented Aug 30, 2024

Let me merge as this PR has got 2 approvals, Michal, @michalvavrik, ping me please if you'd like to add anything

@sberyozkin sberyozkin merged commit 458c705 into quarkusio:main Aug 30, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 30, 2024
@sberyozkin sberyozkin deleted the oidc-client-spi branch August 30, 2024 09:54
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 30, 2024
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation area/oidc kind/enhancement New feature or request release/noteworthy-feature triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OIDC Client SPI
4 participants