-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevUI: Allow regex for defined allowed hosts #42618
DevUI: Allow regex for defined allowed hosts #42618
Conversation
Signed-off-by: Phillip Kruger <[email protected]>
Not sure how to test that :-/ |
Will using a regex as described above work for you ? |
Yes, that looks good to me 👍 |
Status for workflow
|
🎊 PR Preview b7d6639 has been successfully built and deployed to https://quarkus-pr-main-42618-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | JVM Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🚧 |
✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🚧 |
✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🚧 |
Full information is available in the Build summary check run.
Failures
⚙️ JVM Tests - JDK 17 #
- Failing: integration-tests/grpc-cli
📦 integration-tests/grpc-cli
✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy18.corsHandler(Unknown Source)
at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)
⚙️ JVM Tests - JDK 21 #
- Failing: integration-tests/grpc-cli
📦 integration-tests/grpc-cli
✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy10.corsHandler(Unknown Source)
at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)
⚙️ JVM Tests - JDK 17 Windows #
- Failing: integration-tests/grpc-cli
📦 integration-tests/grpc-cli
✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy25.corsHandler(Unknown Source)
at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)
Fix comment in #40979 (comment)
@slallemand please can you test if this solve your issue.
Here is an example usage. Let's say you want to match all subdomains in foo.bar (so http://*.foo.bar) you will use
^([a-zA-Z0-9-]+\.)*foo\.bar(/.*)?$
Let me know