Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevUI: Allow regex for defined allowed hosts #42618

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Aug 19, 2024

Fix comment in #40979 (comment)

@slallemand please can you test if this solve your issue.

Here is an example usage. Let's say you want to match all subdomains in foo.bar (so http://*.foo.bar) you will use ^([a-zA-Z0-9-]+\.)*foo\.bar(/.*)?$

Let me know

@slallemand
Copy link

Not sure how to test that :-/

@phillip-kruger
Copy link
Member Author

Will using a regex as described above work for you ?

@slallemand
Copy link

Yes, that looks good to me 👍

Copy link

quarkus-bot bot commented Aug 19, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 58fef84.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview b7d6639 has been successfully built and deployed to https://quarkus-pr-main-42618-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@phillip-kruger phillip-kruger added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Aug 19, 2024

This comment has been minimized.

Copy link

quarkus-bot bot commented Aug 20, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 58fef84.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
JVM Tests - JDK 21 Build Failures Logs Raw logs 🚧
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/grpc-cli 

📦 integration-tests/grpc-cli

io.quarkus.grpc.cli.GrpcCliTest.testCommand - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy18.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/grpc-cli 

📦 integration-tests/grpc-cli

io.quarkus.grpc.cli.GrpcCliTest.testCommand - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy10.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/grpc-cli 

📦 integration-tests/grpc-cli

io.quarkus.grpc.cli.GrpcCliTest.testCommand - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy25.corsHandler(Unknown Source)
	at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)

@cescoffier cescoffier merged commit 34ca0e0 into quarkusio:main Aug 20, 2024
52 of 55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 20, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants