Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements missing in quarkus-config-javadoc.yaml for types nested more deeply than 1 level #42503

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Elements missing in quarkus-config-javadoc.yaml for types nested more deeply than 1 level #42503

merged 1 commit into from
Aug 13, 2024

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Aug 13, 2024

fix #42501

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 13, 2024

Would you like to review, @gsmet ?

gsmet
gsmet approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, right.

This is a hack as there's no way to ask the annotation processor API if a class is local which is a pity :/

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 13, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5affc06.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit b4e761d into quarkusio:main Aug 13, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 13, 2024
@gsmet
Copy link
Member

gsmet commented Aug 13, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.14.0.CR1
Development

Successfully merging this pull request may close these issues.

Elements missing in quarkus-config-javadoc.yaml for types nested more deeply than 1 level
2 participants
@ppalaga @gsmet