Make the boot jars in jib respect quarkus.jib.use-current-timestamp-file-modification
#42486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Aug 12, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jib plugin does not respect the
quarkus.jib.use-current-timestamp-file-modificationwith the boot jars layer.Itreuses the jar's timestamps because of
AppCDS, even ifAppCDSis absent.This PR only preserves the jar's timestamp if
AppCDSis present, otherwise it reuses the same modification time as the other layers.This allow users to create images with layers that will change less often, for exemple when building in clean environments.