Fix consistency of SmallRye Health config roots #42444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some properties were under the `quarkus.health` prefix and some under the `quarkus.smallrye-health` prefix. I unified everything under `quarkus.smallrye-health` and kept the old properties for backward compatibility (except for the just introduced `enabled`). Fixes quarkusio#42382
gastaldi
approved these changes
Aug 9, 2024
Status for workflow
|
xstefank
reviewed
Aug 9, 2024
| import io.quarkus.test.QuarkusUnitTest; | ||
| import io.restassured.RestAssured; | ||
|
|
||
| @Deprecated(since = "3.14", forRemoval = true) |
There was a problem hiding this comment.
Well, the test can stay right, we just need to update the config? This test needs to be updated nevertheless. Just mentioning it so it's not removed.
There was a problem hiding this comment.
No, the test will get dropped. I added another test with the updated config (but GitHub shows it to you the other way around).
|
Otherwise approved. Sorry, you move too fast for my flow coding time off emails :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some properties were under the
quarkus.healthprefix and some under thequarkus.smallrye-healthprefix.I unified everything under
quarkus.smallrye-healthand kept the old properties for backward compatibility (except for the just introducedenabled).Fixes #42382