Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertx HTTP: execute custom logic when HTTP server is started #42409

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 8, 2024

IMPL. NOTE: I chose CDI async events because it's "safer" compared to @Observes which always blocks the current thread. @ObservesAsync offloads the logic to the default blocking executor (worker thread in case of quarkus-vertx). I mean, we could mention this in the docs, even in javadoc, but that does not prevent users from executing "creative" code in those observers. @ObservesAsync should mitigate the risk a little ;-).

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

This comment has been minimized.

This comment has been minimized.

Copy link

quarkus-bot bot commented Aug 9, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8e2e6e1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2024
Copy link

quarkus-bot bot commented Aug 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8e2e6e1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 2c6d750 into quarkusio:main Aug 9, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 9, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 9, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Provide a way to execute some logic when the HTTP server is started
2 participants