Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proper PU for executeUpdate on entityClass #42400

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 8, 2024

Fixes #42314
Introduced by #41547

@gsmet gsmet requested a review from marko-bekhta August 8, 2024 10:49
@gsmet
Copy link
Member Author

gsmet commented Aug 8, 2024

@marko-bekhta any chance you could add a test to the PR if it's not too convoluted to do it?

This comment has been minimized.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 8, 2024
Copy link

quarkus-bot bot commented Aug 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e3de691.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 59670d7 into quarkusio:main Aug 8, 2024
27 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 8, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 8, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.2 Aug 8, 2024
@yrodiere
Copy link
Member

Introduced by #41547

Sorry. That's indeed embarrassing.

@HerrDerb
Copy link
Contributor

With now using an entity specific session, can this theoretically have a impact on memory and db connections for a complex transaction?

@yrodiere
Copy link
Member

yrodiere commented Sep 11, 2024

In short: no.

Because:

  1. We didn't change the behavior here, we just reverted it to what it was before I introduced a regression by mistake.
  2. We only use different sessions for different entities when you explicitly tell us to. See https://quarkus.io/guides/hibernate-orm#multiple-persistence-units

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JPA writes don't work when using ONLY named data sources since 3.13.0
5 participants