Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring-data-jpa @Modifying(flushAutomatically = true) #42376

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

famod
Copy link
Member

@famod famod commented Aug 7, 2024

Issue spotted by @dreab8: #42322 (comment)

This broke in 3.13.0.CR1 via 6f859d4 (/cc @yrodiere, no fingerpointing - just to make sure I'm not missing anything)

The test didn't catch it because allMatch returns true for an empty collection. See also: https://stackoverflow.com/a/30223378

@famod famod added area/spring Issues relating to the Spring integration triage/backport labels Aug 7, 2024
@famod famod changed the title Fix spring-data-jpa @Modifying(clearAutomatically = true) Fix spring-data-jpa @Modifying(flushAutomatically = true) Aug 7, 2024
@famod famod force-pushed the fix-spring-flushAutomatically branch from c4c57d6 to 5aa3740 Compare August 7, 2024 17:48

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 7, 2024

CI doesn't look happy (but the fix makes sense...)

@famod
Copy link
Member Author

famod commented Aug 7, 2024

I'll have a look. Seems like the test methods are not properly isolated (test order issue; the class passed locally).

@famod famod force-pushed the fix-spring-flushAutomatically branch from 5aa3740 to c23eb63 Compare August 7, 2024 20:30
@famod famod force-pushed the fix-spring-flushAutomatically branch from c23eb63 to 296b43e Compare August 7, 2024 20:51
Copy link

quarkus-bot bot commented Aug 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 296b43e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit a34e10f into quarkusio:main Aug 7, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 7, 2024
@famod famod deleted the fix-spring-flushAutomatically branch August 7, 2024 21:24
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.2 Aug 8, 2024
@yrodiere
Copy link
Member

This broke in 3.13.0.CR1 via 6f859d4 (/cc @yrodiere, no fingerpointing - just to make sure I'm not missing anything)

You're perfectly entitled to fingerpoint here -- I messed up that patch, and not only for this reason. Sorry. Thanks a lot for investigating and fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants