Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next client: support string params for connector.baseUri() #42196

Merged
merged 1 commit into from
Jul 29, 2024
Merged

WebSockets Next client: support string params for connector.baseUri() #42196

merged 1 commit into from
Jul 29, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 29, 2024

@mkouba mkouba requested review from maxandersen and geoand July 29, 2024 07:59
geoand
geoand approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit eb18d0e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit b1de140 into quarkusio:main Jul 29, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 29, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@maxandersen maxandersen Awaiting requested review from maxandersen

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
3.14.0.CR1
Development

Successfully merging this pull request may close these issues.

websocket next client connector.baseUri(server) should allow string
2 participants
@mkouba @geoand