Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when multiple hibernate interceptors are found #42190

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Improve error message when multiple hibernate interceptors are found #42190

merged 4 commits into from
Jul 29, 2024

Conversation

peuBouzon
Copy link
Contributor

@peuBouzon peuBouzon commented Jul 29, 2024 •
edited by geoand
Loading

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/persistence OBSOLETE, DO NOT USE labels Jul 29, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2024

/cc @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search), @yrodiere (hibernate-orm,hibernate-search)

@geoand geoand requested a review from yrodiere July 29, 2024 06:37
yrodiere
yrodiere approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thank you!

I just have one suggestion, but feel free to ignore if you disagree: moving the list of classes near the end of the message could make it easier to read. I added an example in one of the implementations, but it makes sense for all of them.

...ibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/PersistenceUnitUtil.java Outdated Show resolved Hide resolved
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 25626f3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@yrodiere yrodiere merged commit b31c632 into quarkusio:main Jul 29, 2024
41 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 29, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 29, 2024
@yrodiere
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request
Projects
None yet
Milestone
3.14.0.CR1
Development

Successfully merging this pull request may close these issues.

Improve error message when multiple hibernate interceptors are found
2 participants
@peuBouzon @yrodiere