Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage opentelemetry-semconv-incubating #42186

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Manage opentelemetry-semconv-incubating #42186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4b0c5e
Manage opentelemetry-semconv-incubating
ppalaga Jul 28, 2024
65a47aa
Remove superfluous opentelemetry-semconv exclusions on which semconv …
ppalaga Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6443,16 +6443,11 @@
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>${opentelemetry-semconv.version}</version>
<exclusions>
<exclusion>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-bom</artifactId>
</exclusion>
<exclusion>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-api</artifactId>
</exclusion>
</exclusions>
Comment on lines -6446 to -6455
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, you do a bit more than adding something to the BOM as advertised in the title. Could you clarify?

I'm all for what you added below but not sure I would be comfortable merging the part above without having @brunobat checking as it's something that has been added explicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opentelemetry-semconv depends on neither opentelemetry-bom nor opentelemetry-api so the exclusions are completely superfluous. Perhaps they were dependencies in the past. The change is in a separate commit.

</dependency>
<dependency>
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv-incubating</artifactId>
<version>${opentelemetry-semconv.version}</version>
</dependency>

<!-- JDK Flight Recorder -->
Expand Down
Loading