-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --overwrite
argument to devtools/project-core-extension-codestarts
#42153
Conversation
…tarts The change for warning was introduced in gradle/gradle#21959 This change causing the build fail if you build the module project-core-extension-codestarts multiple time. Adding argument --overwrite let the gradle init overwrite existing gradle-wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice detective work!
Status for workflow
|
@gsmet I don't think that backport is needed as #41953 in 3.14 milestone and don't have backport label. Also this option was introduced in gradle 8.9 https://github.com/gradle/gradle/pull/21959/files#diff-295a5e54438bdcc210e645ee1b3f5815aa006bd78ca332072582bc29d10fa669R113 |
@jedla97 thanks for checking! |
Fixes #42111
The change for warning/failing was introduced in gradle/gradle#21959.
This change causing the build fail if you build the module
devtools/project-core-extension-codestarts
multiple time. Adding argument--overwrite
let the gradle init overwrite existinggradle-wrapper
To test it use
mvn -V -B install -f devtools/project-core-extension-codestarts -Dquickly -Prelocations
Before: if you run it 2nd time it fail
Now: It will be build successfully