Extend ReflectiveClassBuildItem to support Class.getClasses()
#42130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking Class.getClasses() requires first registering all declared classes of the class for reflection. This is achieved by setting `allDeclaredClasses` in `reflect-config.json`.
This should come at no cost since the classes are already registered.
gsmet
approved these changes
Jul 25, 2024
Comment on lines
+149
to
+155
| @Deprecated(since = "3.14", forRemoval = true) | ||
| ReflectiveClassBuildItem(boolean constructors, boolean queryConstructors, boolean methods, boolean queryMethods, | ||
| boolean fields, boolean weak, boolean serialization, | ||
| boolean unsafeAllocated, String... className) { | ||
| this(constructors, queryConstructors, methods, queryMethods, fields, false, weak, serialization, unsafeAllocated, | ||
| className); | ||
| } |
There was a problem hiding this comment.
If it's not used, you actually don't need that given it's not public.
There was a problem hiding this comment.
It's only used by two the already deprecated public constructors, but I added the Deprecation notice to make sure people will stop using it internally as well.
zakkak
added
the
triage/waiting-for-ci
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking
Class.getClasses()requires first registering all declared classes of the class for reflection. This is achieved by settingallDeclaredClassesinreflect-config.json.