Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce overhead of REST Client config handling #42100

Closed
wants to merge 1 commit into from
Closed

Reduce overhead of REST Client config handling #42100

wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 24, 2024

The idea here is to reduce the lookups to Smallrye Config while also reducing object creation when those lookups are necessary

@geoand geoand requested a review from cescoffier July 24, 2024 10:06
@geoand geoand mentioned this pull request Jul 24, 2024
Open
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor Author

geoand commented Jul 24, 2024

The CI issue should now be fixed

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 24, 2024
@geoand
Reduce overhead of REST Client config handling
fb914ec 
The idea here is to reduce the lookups to Smallrye Config
while also reducing object creation when those lookups are
necessary

Relates to: quarkusio#42092
@geoand geoand mentioned this pull request Jul 24, 2024
Merged
@geoand geoand added triage/on-ice Frozen until external concerns are resolved and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 24, 2024
@geoand
Copy link
Contributor Author

geoand commented Jul 24, 2024

Putting this on ice because of #42106

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 24, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fb914ec.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand closed this Jul 25, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/rest area/resteasy-classic triage/invalid This doesn't seem right triage/on-ice Frozen until external concerns are resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @cescoffier