WebSockets Next: honor the quarkus.http.root-path correctly

[mkouba]

• i.e. do not use HttpRootPathBuildItem together with RouteBuildItem.builder()

[geoand]

So we need to figure out if we want this or not :)

[mkouba]

So we need to figure out if we want this or not :)

Well, the opening handshake goes over HTTP so I'd say we want this 🤷

[geoand]

Clement and I were both wondering on the Zulip thread... I am still unconvinced

[cescoffier]

I agree with Martin because of the "upgrade" HTTP request.

It could be debatable when you would use a direct, without-upgrade approach, but the initial HTTP request should honor the root path.

Also, I think it's more consistent from a user POV.

[cescoffier]

The documentation should mention this.

[geoand]

The documentation should mention this.

Definitely

[mkouba]

The documentation should mention this.

Done.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ae33dc9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ae33dc9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[github-actions]

🙈 The PR is closed and the preview is expired.