Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SmallRye Fault Tolerance 6.4.0 #42031

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jul 22, 2024

The code changes here are:

  • the upgrade itself
  • support for @BeforeRetry, which is a new feature in this release

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/fault-tolerance area/smallrye labels Jul 22, 2024
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@geoand
Copy link
Contributor

geoand commented Jul 22, 2024

Should we backport this into 3.13.0?

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 22, 2024
@gsmet
Copy link
Member

gsmet commented Jul 22, 2024

FWIW, I think it might be a bit too late for that but if we really think it's needed, I could be convinced.

@geoand
Copy link
Contributor

geoand commented Jul 22, 2024

No strong opinion on my side, I'll remove the label for now

Copy link

quarkus-bot bot commented Jul 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d2f6b82.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@gsmet gsmet merged commit 78fdb1d into quarkusio:main Jul 22, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 22, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 22, 2024
@Ladicek Ladicek deleted the smallrye-fault-tolerance-6.4.0 branch July 23, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants