Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a text based 404 based on useragent #41989

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

phillip-kruger
Copy link
Member

Fix #41969

image

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand
Copy link
Contributor

geoand commented Jul 19, 2024

@phillip-kruger mind rebasing, the PR seems stuck for some reason

@gsmet gsmet force-pushed the user-agent-aware-404 branch from c5500fd to 3eff48e Compare July 20, 2024 12:15
@gsmet
Copy link
Member

gsmet commented Jul 20, 2024

Rebased as Saturday is a quiet day :).

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I agree it looks like a neat idea. Ideally it should be based on the Accept header instead of catching the user agent but I would merge it and see if someone complains at some point.

That being said, I suggested to make the user agent test a lot stricter as the current one is very broad.

This comment has been minimized.

@phillip-kruger phillip-kruger requested a review from gsmet July 21, 2024 10:46
Copy link

quarkus-bot bot commented Jul 21, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c6a8248.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

📦 integration-tests/hibernate-reactive-panache

io.quarkus.it.panache.reactive.NoPagingPMT.test - History

  • Read timed out - java.net.SocketTimeoutException
java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:278)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:304)
	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:346)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:796)
	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:1099)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
	at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)

@gsmet gsmet merged commit 265b721 into quarkusio:main Jul 21, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 21, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response when invalid endpoint is called be agent responsive
3 participants