Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Remove conditionalization from Wiremock section #41980

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 18, 2024

Cherry Picked from 8da8697
xref: #41977

Remove :no-deprecated-test-resource[] conditionalization from Wiremock and OidcTestClient content in response to review comments such as:

#41834 (comment)
#41834 (comment)
#41834 (comment)
#41834 (comment)

When all PRs are approved, we should be able to synch and publish the Security Guides for RHBQ 3.8.

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 18, 2024

When all PRs are approved and merged in the following order, I should finally be able to synch and publish the Security Guides for RHBQ 3.8:

  1. [3.8] Apply QE feedback to community docs #41834
  2. Remove conditionalization from Wiremock section #41977
  3. [3.8] Remove conditionalization from Wiremock section #41980

This comment has been minimized.

@rolfedh rolfedh requested a review from gsmet July 18, 2024 15:05

This comment has been minimized.

@rolfedh rolfedh marked this pull request as draft July 18, 2024 17:07
@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 19, 2024

I'm putting this PR on hold (Draft) for now.
I will rebase and re-cherry-pick this PR after #41834 merges.
This is necessary because this PR reverses some of the changes in 41834.
I'm doing this because it's my understanding that a best practice is to maintain matching or parallel sets of PRs for main and corresponding cherry-pick PRs for 3.8.

@rolfedh rolfedh marked this pull request as ready for review July 19, 2024 14:50
Copy link

quarkus-bot bot commented Jul 19, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 00691de.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit 35c370a into quarkusio:3.8 Jul 19, 2024
5 checks passed
@sberyozkin sberyozkin deleted the cp-41977-to-3.8 branch July 19, 2024 15:42
Copy link

🙈 The PR is closed and the preview is expired.

@gsmet gsmet added this to the 3.8.6 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

4 participants