Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Update content for support of quarkus-oidc-token-propagation-(reactive) extensions #41950

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 17, 2024

Cherry Picked from d14c8be
xref: #41938

…-rest-client-oidc-token-propagation support in RHBQ
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jul 17, 2024
@rolfedh rolfedh marked this pull request as draft July 17, 2024 11:42
@rolfedh rolfedh marked this pull request as ready for review July 17, 2024 11:47
@rolfedh rolfedh requested review from rsvoboda and sberyozkin July 17, 2024 11:47
Copy link

quarkus-bot bot commented Jul 17, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9b60c8d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member

@rolfedh Are you going to manage these exclusions at the products docs level ?

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 17, 2024

@rolfedh Are you going to manage these exclusions at the products docs level ?

Hi @sberyozkin

From what I understand, @rsvoboda states that these extensions are now Tech Preview in both 3.8 and 3.14.

They also appear as Tech Preview for 3.8 on code.quarkus.redhat.com.

Based on our previous team discussions, Tech Preview extensions are supported: 3-13-SJ-MA-RS-Copy of QDOCS-660: Supported/unsupported extensions in the upstream>downstream documentation.

So, it seems like exclusions are no longer necessary on the 3.8 branch. Right?

Best,
Rolfe

@sberyozkin
Copy link
Member

Thanks for the clarification @rolfedh. LGTM.

@rsvoboda rsvoboda merged commit aa05b4d into quarkusio:3.8 Jul 18, 2024
5 checks passed
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gsmet, please check and merge if it looks good to you

@rsvoboda
Copy link
Member

Sorry, I merged already ...

Copy link

🙈 The PR is closed and the preview is expired.

@sberyozkin
Copy link
Member

@rsvoboda OK, thanks for merging, I was not sure I could merge to 3.8

@sberyozkin sberyozkin deleted the cp-41938-to-3.8 branch July 18, 2024 08:28
@rsvoboda
Copy link
Member

I'm on triage call, I can discuss it with Guillaume if he is not happy that I merged this.

@sberyozkin
Copy link
Member

Sure, I think Guillaume prefers to manage all the backports in general, but as long as he is aware, it should be fine I hope

@rsvoboda
Copy link
Member

rsvoboda commented Jul 18, 2024

Well, the ideal case is to add triage/backport-3.8 label on the original PR and it will be cherry-picked during the backports/triage session. No need to do these individual PRs if the change is applicable to 3.8 stream.

@rolfedh can you set labels on PRs?

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 18, 2024

Well, the ideal case is to add triage/backport-3.8 label on the original PR and it will be cherry-picked during the backports/triage session. No need to do these individual PRs if the change is applicable to 3.8 stream.

@rolfedh can you set labels on PRs?

Sure, I can set the labels without any problem. However, I prefer doing the manual cherry-picks because I sometimes encounter merge conflicts or other issues that need inspection. How often does the backports/triage session happen?

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 18, 2024

Thank you both for the reviews and merges, @sberyozkin and @rsvoboda!

@rsvoboda
Copy link
Member

How often does the backports/triage session happen?

There is no regular cadence, they are usually initiated when RHBQ discussions about the new version appear. With some plans about regular cadence, this shouldn't be an issue going forward. No promises though ;)

@gsmet gsmet added this to the 3.8.6 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

4 participants