Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to SmallRye GraphQL 2.9.0 #41822

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Jul 11, 2024

Copy link

quarkus-bot bot commented Jul 11, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@jmartisk jmartisk force-pushed the smallrye-graphql-2.9.0 branch from 1a8f649 to 066ef6a Compare July 11, 2024 06:56
@@ -0,0 +1,5 @@
{
"data": {
"importantDatesUS": null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary hack, I think this may be a bug in smallrye-graphql, so just making the test pass. I'll file an issue

@geoand geoand requested a review from phillip-kruger July 11, 2024 07:10
@geoand geoand changed the title SmallRye GraphQL 2.9.0 Bump to SmallRye GraphQL 2.9.0 Jul 11, 2024
@gsmet
Copy link
Member

gsmet commented Jul 11, 2024

@jmartisk as mentioned by the bot, it would be nice if you could include a link to the GH change log in the description.

Copy link

quarkus-bot bot commented Jul 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 066ef6a.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - HTTP Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Native Tests - HTTP #

- Failing: integration-tests/vertx-graphql 

📦 integration-tests/vertx-graphql

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-vertx-graphql: Failed to build quarkus application

@jmartisk jmartisk merged commit 24326d0 into quarkusio:main Jul 11, 2024
51 of 52 checks passed
@jmartisk jmartisk deleted the smallrye-graphql-2.9.0 branch July 11, 2024 12:43
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 11, 2024
@gsmet
Copy link
Member

gsmet commented Jul 11, 2024

@jmartisk hmmm, doens't the failure reported above look related to your PR?

@jmartisk
Copy link
Contributor Author

Ah crap. Sorry, I'll look into it asap

@jmartisk
Copy link
Contributor Author

jmartisk commented Jul 11, 2024

Yeah the vertx-graphql processor will need the same RuntimeInitializedClassBuildItem that I added for smallrye. PR coming in a few mins, sorry (I'm being too fast trying to finish up stuff before PTO)

@gsmet
Copy link
Member

gsmet commented Jul 11, 2024

No worries, shit happens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/graphql area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants