Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: tidy comments which are no longer applicable #41715

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Trivial: tidy comments which are no longer applicable #41715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration-tests/main/src/test/java/io/quarkus/it/main/MethodSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,10 @@ public void testParameterResolver(UnusedBean.DummyInput dummyInput, Matcher<Stri
private static Collection<Arguments> provideDummyInput() {
return List.of(
Arguments.of(
// note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
new UnusedBean.DummyInput("whatever",
new UnusedBean.NestedDummyInput(new ArrayList<>(List.of(1, 2, 3)))),
CoreMatchers.is("whatever/6")),
Arguments.of(
// note: Collections.emptyList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
new UnusedBean.DummyInput("hi", new UnusedBean.NestedDummyInput(new ArrayList<>())),
CoreMatchers.is("hi/0")));
}
Expand Down
3 changes: 0 additions & 3 deletions integration-tests/main/src/test/java/io/quarkus/it/main/ParameterResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
@Override
public Object resolveParameter(ParameterContext parameterContext,
ExtensionContext extensionContext) throws ParameterResolutionException {
// note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
return new UnusedBean.DummyInput("whatever", new UnusedBean.NestedDummyInput(new ArrayList<>(List.of(1, 2, 3))));
}
}
Expand All @@ -78,7 +77,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext)
throws ParameterResolutionException {
return (Supplier<UnusedBean.DummyInput>) () -> new UnusedBean.DummyInput("fromSupplier",
// note: Collections.emptyList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
new UnusedBean.NestedDummyInput(new ArrayList<>()));
}
}
Expand Down Expand Up @@ -109,7 +107,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
@Override
public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext)
throws ParameterResolutionException {
// note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
return new ArrayList<>(List.of(new NonSerializable("foo"), new NonSerializable("bar")));
}
}
Expand Down
3 changes: 0 additions & 3 deletions integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
/**
* Exercise {@link ParameterizedTest @ParameterizedTest}s.
*
* <p>
* This test will run into <a href="https://github.com/x-stream/xstream/issues/253">x-stream/xstream#253</a> on Java 16 and
* newer if the custom XStream converters are not used
*/
@QuarkusTest
public class ParamsTest {
Expand Down