-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for canceling async types in Quarkus Rest #41710
Conversation
Thanks for putting this together so fast :-) How do I test? Is there a maven repo I can use once the CI is done? Also, to answer your question, I thought this could be a configurable option. |
Very true. If we decide to add one that preserves the old behavior, I'll remove the label.
You need to checkout https://github.com/geoand/quarkus and use the
Then update your project to use version |
@cescoffier @gsmet what do you think of the breaking aspect of this? Perhaps we don't have to worry about it as it's clearly a very small niche? |
Status for workflow
|
I would. It worry too much. The new behavior is the correct one. |
When the underlying connection is closed, we can now cancel the underlying pipeline when an async type is supported.
Question: Should this be configurable? I am wondering because it is not unimaginable that some people might relying on the pipeline being completed in some fire and forget scenario.
Based on the scenario I explained above, I consider this a breaking change (albeit unlikely to break many people...)