Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native issue with @Providers when only the REST Client exists #41707

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 5, 2024

When the server part of Quarkus REST is not included, prior to this change, user's @Provider classes were not registered for reflection

Relates to: quarkiverse/quarkus-langchain4j#722

@geoand geoand requested a review from cescoffier July 5, 2024 09:25
@quarkus-bot quarkus-bot bot added the area/rest label Jul 5, 2024
When the server part of Quarkus REST is not included, prior to
this change, user's @Provider classes were not registered
for reflection

Relates to: quarkiverse/quarkus-langchain4j#722
Copy link

quarkus-bot bot commented Jul 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2a567df.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 7720a88 into quarkusio:main Jul 5, 2024
27 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 5, 2024
@geoand geoand deleted the client-only-providers branch July 5, 2024 12:49
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.2 Jul 9, 2024
@gsmet gsmet modified the milestones: 3.12.2, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants