Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only warn about module-info if it exists #41670

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Only warn about module-info if it exists #41670

merged 1 commit into from
Jul 4, 2024

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Jul 3, 2024 •
edited by geoand
Loading

@dmlloyd dmlloyd mentioned this pull request Jul 3, 2024
Closed
@quarkus-bot quarkus-bot bot added the area/core label Jul 3, 2024
@gsmet
Copy link
Member

gsmet commented Jul 3, 2024

Ah indeed... I didn't look at the code and I should have :).

I'll test it tomorrow!

gsmet
gsmet approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue, thanks!

@gsmet gsmet merged commit 684d70a into quarkusio:main Jul 4, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 4, 2024
@dmlloyd dmlloyd deleted the fix-41669 branch July 5, 2024 12:34
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.2 Jul 9, 2024
@gsmet gsmet modified the milestones: 3.12.2, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.8.6
Development

Successfully merging this pull request may close these issues.

Dev mode always complaining about module-info not being supported
5 participants
@dmlloyd @gsmet @gastaldi @aloubyansky @geoand