-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional recipe artifacts in quarkus update #41663
Support additional recipe artifacts in quarkus update #41663
Conversation
If you keep the other PR and rename the param to additionalRecipeCoords, then you don't need to specify the quarkus core one |
we can change the attribute to be |
changed naming to |
should be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good !
This comment has been minimized.
This comment has been minimized.
10c1ef8
to
b65c70c
Compare
b65c70c
to
0ae63d5
Compare
I cleaned the logs, squashed and rebased. I am wondering if we should keep the |
Status for workflow
|
CI finally green @gsmet |
@vsevel wait we might need to rename again following @maxandersen review:
|
@vsevel ok since there is no release planned, let's merge this and I'll rename both in my following PR Thanks for this!! |
This is adding support for a
updateRecipeArtifactCoordinates
property in maven/gradle/cli for quarkus update, which allows to specify several artifacts containing update recipes.this as been tested so far with
mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:update -N -DupdateRecipeArtifactCoordinates=org.acme:quarkusupdate:1.0.0-SNAPSHOT,io.quarkus:quarkus-update-recipes:LATEST -DrewriteDryRun=true
with a
3.12.yaml
recipe file in moduleorg.acme:quarkusupdate
containing:when running against a
3.8.5
project, this produces the following build log:and the diff looks like:
gradle support has not been done yet.
this has not been rebased onto the other PR (wondering if we really need to).
some logging has been added for debugging purposes, but will be removed before merge.
this is created as a draft to get some early feedback from @ia3andy