Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis Client: fix JSON.MGET parameters ordering #41614

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Redis Client: fix JSON.MGET parameters ordering #41614

merged 1 commit into from
Jul 2, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jul 2, 2024

Fixes #41611

@Ladicek Ladicek requested a review from cescoffier July 2, 2024 12:47
@Ladicek
Copy link
Contributor Author

Ladicek commented Jul 2, 2024

This is technically a breaking change, but a minor one I believe? And it actually makes the API behave as intended.

@Ladicek Ladicek mentioned this pull request Jul 2, 2024
Closed
@gsmet
Copy link
Member

gsmet commented Jul 2, 2024

I think it's worth fixing it. If it gets in, please add an entry in the migration guide for 3.13.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 2, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7bf5773.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier
Copy link
Member

Definitely a breaking change, but yes, we must fix this. Thanks!

@cescoffier cescoffier merged commit 16c6ef9 into quarkusio:main Jul 2, 2024
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 2, 2024
@Ladicek Ladicek deleted the fix-redis-client-json-mget branch July 2, 2024 14:28
@Ladicek
Copy link
Contributor Author

Ladicek commented Jul 2, 2024

Added a short notice to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/redis kind/bugfix release/breaking-change
Projects
None yet
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.

quarkus-redis-client : JSON.MGET returning null
3 participants
@Ladicek @gsmet @cescoffier