Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liquibase issue with resource path #41530

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix liquibase issue with resource path #41530

merged 1 commit into from
Jul 3, 2024

Conversation

juanjogv
Copy link
Contributor

@juanjogv juanjogv commented Jun 27, 2024

now it compiles successfully the native image

image

This comment was marked as resolved.

@juanjogv juanjogv changed the title fixing bug described in issue #41236 fixing bug described in issue #41236 about liquibase extension Jun 27, 2024
@juanjogv juanjogv changed the title fixing bug described in issue #41236 about liquibase extension Fixing bug described in issue #41236 about liquibase extension Jun 27, 2024
@juanjogv juanjogv changed the title Fixing bug described in issue #41236 about liquibase extension Fix #41236 about liquibase extension Jun 27, 2024
@geoand geoand changed the title Fix #41236 about liquibase extension Fix liquibase issue with resource path Jun 28, 2024
Copy link

quarkus-bot bot commented Jun 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5813d9c.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Initial JDK 17 Build #

- Failing: extensions/liquibase/deployment 
! Skipped: docs integration-tests/liquibase 

📦 extensions/liquibase/deployment

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.24.1:validate (default) on project quarkus-liquibase-deployment: File '/home/runner/work/quarkus/quarkus/extensions/liquibase/deployment/src/main/java/io/quarkus/liquibase/deployment/LiquibaseProcessor.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/liquibase/deployment net.revelc.code.formatter:formatter-maven-plugin:2.24.1:format`) and commit before running validation!

@gsmet
Copy link
Member

gsmet commented Jul 1, 2024

I force pushed a small formatting change to make CI happier.

@geoand I let you review this one as you already tried to fix this? I think I would like an IT there because it's not ideal to only have the quickstarts failing.

@gsmet
Copy link
Member

gsmet commented Jul 1, 2024

Oh and sorry, I should have started with that: thanks for the patch and taking the time to fight this issue!

@geoand
Copy link
Contributor

geoand commented Jul 1, 2024

I remember seeing the original issue, but not trying to fix it :)

I think I would like an IT

That would be great! @juanjogv do you mind updating the Flyway integration test to introduce this check?

@juanjogv
Copy link
Contributor Author

juanjogv commented Jul 3, 2024

@geoand sure I can do it, but it will take me a bit of time as I have no experience with IT on extensions, if that's not a problem, no biggie for me.

@geoand
Copy link
Contributor

geoand commented Jul 3, 2024

No problem at all

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and create an additional PR for the IT you will add.

Ping us if you need any help (you can create a draft PR and we can discuss there)

@gsmet gsmet merged commit f483848 into quarkusio:main Jul 3, 2024
18 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 3, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.2 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liquibase fails when changelog file is not the default resource path
3 participants