-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix liquibase issue with resource path #41530
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ Initial JDK 17 Build #
- Failing: extensions/liquibase/deployment
! Skipped: docs integration-tests/liquibase
📦 extensions/liquibase/deployment
✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.24.1:validate (default) on project quarkus-liquibase-deployment: File '/home/runner/work/quarkus/quarkus/extensions/liquibase/deployment/src/main/java/io/quarkus/liquibase/deployment/LiquibaseProcessor.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/liquibase/deployment net.revelc.code.formatter:formatter-maven-plugin:2.24.1:format`) and commit before running validation!
I force pushed a small formatting change to make CI happier. @geoand I let you review this one as you already tried to fix this? I think I would like an IT there because it's not ideal to only have the quickstarts failing. |
Oh and sorry, I should have started with that: thanks for the patch and taking the time to fight this issue! |
I remember seeing the original issue, but not trying to fix it :)
That would be great! @juanjogv do you mind updating the Flyway integration test to introduce this check? |
@geoand sure I can do it, but it will take me a bit of time as I have no experience with IT on extensions, if that's not a problem, no biggie for me. |
No problem at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it and create an additional PR for the IT you will add.
Ping us if you need any help (you can create a draft PR and we can discuss there)
now it compiles successfully the native image