Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AI category #41425

Merged
merged 3 commits into from
Nov 12, 2024
Merged

add AI category #41425

merged 3 commits into from
Nov 12, 2024

Conversation

maxandersen
Copy link
Member

@maxandersen maxandersen commented Jun 25, 2024

related to quarkiverse/quarkus-langchain4j#704

@ia3andy the ai category won't be relevant for product nor is the pinned extension in platform so should I remove the pin?

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jun 25, 2024
Copy link

quarkus-bot bot commented Jun 25, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@maxandersen maxandersen marked this pull request as ready for review July 11, 2024 11:17
@maxandersen
Copy link
Member Author

removed the pinning as it is referring to quarkiverse that might not be available for a platform.

but lets get it added thus marking ready for review

This comment has been minimized.

@maxandersen
Copy link
Member Author

@ia3andy any update here?

@ia3andy
Copy link
Contributor

ia3andy commented Sep 20, 2024

@maxandersen I am not sure what you mean?

@maxandersen
Copy link
Member Author

@ia3andy ok to merge ?

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid json

@cescoffier
Copy link
Member

@maxandersen Can you apply the suggestion and produce valid JSON :-)

Copy link

quarkus-bot bot commented Nov 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit abd1f10.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier
Copy link
Member

@ia3andy Can you do another quick review?

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cescoffier
Copy link
Member

Thanks @ia3andy! That was fast (or very reactive ;-))

@cescoffier cescoffier merged commit f7c8927 into quarkusio:main Nov 12, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants