-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AI category #41425
add AI category #41425
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
devtools/bom-descriptor-json/src/main/resources/catalog-overrides.json
Outdated
Show resolved
Hide resolved
removed the pinning as it is referring to quarkiverse that might not be available for a platform. but lets get it added thus marking ready for review |
This comment has been minimized.
This comment has been minimized.
@ia3andy any update here? |
@maxandersen I am not sure what you mean? |
@ia3andy ok to merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
devtools/bom-descriptor-json/src/main/resources/catalog-overrides.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid json
@maxandersen Can you apply the suggestion and produce valid JSON :-) |
…des.json Co-authored-by: Andy Damevin <[email protected]>
Status for workflow
|
@ia3andy Can you do another quick review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @ia3andy! That was fast (or very reactive ;-)) |
related to quarkiverse/quarkus-langchain4j#704
@ia3andy the ai category won't be relevant for product nor is the pinned extension in platform so should I remove the pin?